refactor: add compare module, move Grid/Scenario check functions from PostREISE to PowerSimData #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rouille
reviewed
Jun 24, 2021
jenhagg
reviewed
Jun 24, 2021
jenhagg
reviewed
Jun 24, 2021
danielolsen
force-pushed
the
daniel/compare_module
branch
from
6199c96 to
1876932
Compare
BainanXia
reviewed
Jun 24, 2021
BainanXia
reviewed
Jun 24, 2021
BainanXia
reviewed
Jun 24, 2021
danielolsen
force-pushed
the
daniel/compare_module
branch
2 times, most recently
from
04b0640 to
a808ad6
Compare
BainanXia
approved these changes
Jun 24, 2021
rouille
approved these changes
Jun 24, 2021
|
Per discussion at Breakthrough-Energy/PostREISE#310, we probably also want to move |
Your call |
danielolsen
force-pushed
the
daniel/compare_module
branch
from
a808ad6 to
c744006
Compare
danielolsen
force-pushed
the
daniel/compare_module
branch
from
c744006 to
b46cae3
Compare
This was referenced Jun 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request doc
Purpose
powersimdata.design.compare, to consolidate code which compares Grid data tables.What the code is doing
powersimdata.design.comparegets comparison logic that had been performed elsewhere in PowerSimData or PostREISE.powersimdata.design.investmentuses the newly consolidated comparison logic.powersimdata.input.checkandpowersimdata.scenario.checkget the Grid and Scenario check functions (with associated tests).Testing
Existing unit tests still pass. The existing comparison logic in PowerSimData was untested, but now has a path to getting tests, since it is separated from the broader investment cost calculations.
Where to look
The only real new code is in
powersimdata.design.compare.generation, since it is more robust than what we had before incalculate_gen_inv_costs. Everything else is just moved from elsewhere, with references updated.Time estimate
15-30 minutes.